Removed checking for valid arguments for python tests execution #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquidute
requested review from
ccruzagralopes,
mikaelhm,
fabiowmm,
antonio-amjr and
hiltonlima
test_collections/sdk_tests/support/python_testing/models/utils.py
Outdated
Show resolved
Hide resolved
hiltonlima
reviewed
Dec 13, 2023
ccruzagralopes
approved these changes
Dec 13, 2023
test_collections/sdk_tests/support/python_testing/models/utils.py
Outdated
Show resolved
Hide resolved
hiltonlima
approved these changes
Dec 13, 2023
mikaelhm
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Removed the checking for valid arguments when running python tests. We intend to remove any dependency regarding python arguments between TH and SDK. If any parameter in Python test were added in SDK we would have to update the valid args list in TH backend code.
Removed
endpoint_idattribute indefault_test_environment.configbecause this parameter is no longer defined in the pydantic model and must be defined in test_parameter when necessary.Testing